Commit Graph
6067 Commits
Author SHA1 Message Date
qazalandGitHub 44f1f45cd5 llama: custom silu kernels (#17462)
* start by copying the C

* uop kernel

* cleanup tests

* estimates is part of SPEC
2026-08-10 16:43:01 +09:00
George HotzandGitHub d4d537c8ae add SPEC checking for the kernel graph (#17432)
Unit Tests / Null Tests (pull_request) Failing after 22s
Unit Tests / Unit Tests (pull_request) Failing after 22s
Unit Tests / Docs (pull_request) Failing after 34s
Unit Tests / Fuzzing (pull_request) Failing after 26s
Unit Tests / Torch Backend Tests (pull_request) Failing after 57s
Unit Tests / CL IMAGE Tests (pull_request) Failing after 42s
Unit Tests / Test LLM (pull_request) Failing after 12s
Unit Tests / openpilot Compile Tests (pull_request) Failing after 48s
Unit Tests / Linters (pull_request) Failing after 1m29s
Unit Tests / Optimization Tests (pull_request) Failing after 52s
Unit Tests / Linux (DEV=CL) (pull_request) Failing after 42s
Unit Tests / Linux (DSP) (pull_request) Successful in 1m46s
Unit Tests / Python Backend (pull_request) Failing after 3m11s
Unit Tests / Linux (DEV=CPU:X86) (pull_request) Failing after 24s
Unit Tests / SPEC=2 (2) (pull_request) Successful in 3m53s
Unit Tests / SPEC=2 (1) (pull_request) Successful in 4m4s
Unit Tests / Linux (am) (pull_request) Canceled after 0s
Unit Tests / Linux (amd gfx1100) (pull_request) Canceled after 0s
Unit Tests / Linux (amdllvm gfx1100) (pull_request) Canceled after 0s
Unit Tests / Linux (amd gfx1201) (pull_request) Canceled after 0s
Unit Tests / Linux (amdllvm gfx1201) (pull_request) Canceled after 0s
Unit Tests / Linux (amd gfx950) (pull_request) Canceled after 0s
Unit Tests / Linux (amdllvm gfx950) (pull_request) Canceled after 0s
Unit Tests / Linux (nv) (pull_request) Canceled after 0s
Unit Tests / Linux (ptx) (pull_request) Canceled after 0s
Unit Tests / MacOS (unit) (pull_request) Canceled after 0s
Unit Tests / MacOS (unit, mock) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=METAL) (1) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=METAL) (2) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=CPU:CLANG) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=CPU:LLVM) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=CPU:LVP) (pull_request) Canceled after 0s
Unit Tests / MacOS (DEV=WEBGPU) (pull_request) Canceled after 0s
Unit Tests / Windows (DEV=CPU:CLANG) (pull_request) Canceled after 0s
Unit Tests / Windows (DEV=CPU:LLVM) (pull_request) Canceled after 0s
Unit Tests / Windows (DEV=CPU:X86) (pull_request) Canceled after 0s
Unit Tests / Windows (DEV=WEBGPU) (pull_request) Canceled after 0s
Unit Tests / Compile-only (ir3) (pull_request) Canceled after 0s
Unit Tests / Compile-only (nak) (pull_request) Canceled after 0s
Unit Tests / Compile-only (QCOM CL) (pull_request) Canceled after 0s
Check Line Counts / Check PR Branch status (pull_request_target) Canceled after 0s
Check Line Counts / Core Library Line Difference (pull_request_target) Canceled after 0s
Unit Tests / Linux (DEV=CPU:LVP) (pull_request) Canceled after 1m10s
Unit Tests / Models (pull_request) Canceled after 3m4s
Unit Tests / hcq2 (pull_request) Canceled after 17s
Unit Tests / AMD ASM IDE (pull_request) Canceled after 28s
Unit Tests / Linux (DEV=CPU:CLANG) (pull_request) Canceled after 2m35s
Unit Tests / Linux (DEV=WEBGPU) (pull_request) Canceled after 51s
Unit Tests / Linux (DEV=CPU:LLVM) (pull_request) Canceled after 2m17s
Unit Tests / ONNX (CPU) Tests (pull_request) Canceled after 3m46s
* add SPEC checking for the kernel graph

* skip test

* raise there, not None

* handwritten

* issue with unshard

* multi works

* and bitcast

* fix new tests

* fix linear

* remove call index

* fix shrink

* fixes
2026-08-08 10:00:06 -07:00
b1tgandGitHub abe2256299 fix symbolic sharded reshape (#17463) 2026-08-08 09:18:02 -07:00
b1tgandGitHub 8c49a7a34b support symbolic shapes in copy (#17461)
* pad_to is no-op when same shape

* support symbolic shapes in copy
2026-08-08 09:16:59 -07:00
nimlgenandGitHub 4c206a52b1 fix ci emu (gpt) (#17437)
* fix ci emu

* x
2026-08-07 22:36:59 +03:00
chenyuandGitHub 4a3b8f6501 better _drop_valid_stmts [pr] (#17454) 2026-08-07 15:18:35 -04:00
chenyuandGitHub f76422b8af fix cast to float _min_max [pr] (#17451) 2026-08-07 11:56:19 -04:00
Robert JosephandGitHub 0c96cdc300 fix prod gradients at zero (#17404) 2026-08-07 09:56:52 -04:00
chenyuandGitHub baa6148066 fix var of large half input (#17444)
* fix var of large half input

similar to mean, we use sum_acc_dtype for denominator

* mypy
2026-08-06 23:14:32 -04:00
f253c4469d remove contiguous from custom_kernel (#17149)
* no user contig on custom_kernel

* clean up

* non removable

* test MXFP4 llama without hipcc

* use compiler-free HIPCC renderer in llama CI

* move llama coverage to AMD tests

* run llama coverage in AMD test matrix

* respect configured ROCm path in llama profile

* work

* clean up

* fix

* add views back

* remove that

* update test

* test_double_permute one less kernel

* test_shrink less kernels

---------

Co-authored-by: George Hotz <[email protected]>
2026-08-07 11:20:59 +09:00
chenyuandGitHub 28195d51fb fix f2f from fp8e5m2fnuz to half (#17442)
* fix f2f from fp8e5m2fnuz to half

* it works if it's supported
2026-08-06 21:19:46 -04:00
chenyuandGitHub 9020a88f03 truncate float in DType.const [pr] (#17439) 2026-08-06 20:19:08 -04:00
qazalandGitHub f258708d7d llama: custom quantize_mxfp4+transpose kernel (codex) (#17434)
* llama: custom quantize_mxfp4+transpose kernel (codex)

* rename to cpp

* inline

* cleanup

* lds load_bf16x4

* more tests, add Estimates
2026-08-06 16:13:28 +09:00
chenyuandGitHub 28e6ef6937 fix postopt symbolic [pr] (#17433)
REDUCE with src simplied to const would become unparented
2026-08-06 00:12:30 -04:00
chenyuandGitHub 7a9cd8e329 move weak function and pm to uop/weak [PR] (#17429) 2026-08-05 22:27:40 -04:00
George HotzandGitHub b4372df9c6 revert wrong custom kernel fix (#17427) 2026-08-05 18:31:35 -07:00
sirhcmandGitHub be25207a7a scope variable names inside CALLs (#17424) 2026-08-05 20:59:09 -04:00
chenyuandGitHub d726e5f7f3 split pm_fold_cast_const [PR] (#17425)
need to delete this rule that writes strong typed CONST
2026-08-05 19:56:04 -04:00
George HotzandGitHub 470c032a5e fix slice + non contig kernels (#17423)
* movement: resolve negative int slice bounds against symbolic sizes

negative int bounds in a slice against a symbolic dim were passed through
unresolved, giving wrong views. resolve them against the (possibly
symbolic) size, like slice.indices does for int dims

* schedule: realize custom kernel inputs that don't resolve to a buffer state

rangeify assigns ranges backward from consumers and CALL contributes none,
so the subgraph above a custom kernel input gets no ranges unless something
in it is realized, and reduce conversion crashes with a KeyError. realize
call inputs that don't resolve to a buffer state.

only view-only movement ops preserve the underlying buffer: anything
computed (ALU, REDUCE, ...) must be realized even if one of its sources
resolves to a buffer, since the whole subgraph above the call has no
ranges. unwrapping src[0] unconditionally missed const branches hanging
off non-src[0] children and silently resolved REDUCEs to their source
buffer. includes regression tests for pure const, mixed buffer+const, and
view-over-buffer inputs
2026-08-05 16:18:17 -07:00
George HotzandGitHub 581bfdd94f merge track_rewrites and profile_matches into rewrite_group [PR] (#17420)
* merge track_rewrites and profile_matches into rewrite_group

* bug

* flip ctx polarity
2026-08-05 14:41:38 -07:00
chenyuandGitHub c2f1e5ae2a fix weak cast to strong dtype [pr] (#17418)
weak can mean higher than that strong dtype, so always use that strong dtype is wrong
2026-08-05 15:32:23 -04:00
chenyuandGitHub 6cb419b9b7 regression test for bert nan with weak (#17412) 2026-08-05 12:14:26 -04:00
chenyuandGitHub 3bf9e70b19 Revert "don't cast weak in _broadcasted [pr] (#17408)" (#17409)
This reverts commit b45058b5ec.
2026-08-05 02:40:33 -04:00
77e124e455 fix AMD WMMA emulation and test in CI (#17184)
* fix SPEC=1 test_tensor_cores

* implement i32 WMMA for RDNA3, add regression test to CI

* gfx950 scaled mfma llvmir fix

* detect VOP3PX2 in emu

* start cdna4 scaled mfam emu

* fix gfx12 llvmir signatures

* oops

* fix

* fix src2 const field extraction (gpt)

* scaled mfma fixes cdna4 (kimi)

* fp8 out breaks mfma (glm)

* fix const signature

* another

* fix f string for linter

* lint

* clean

* and a final lint

* .

* fix mypy

* skip slow tests on ci

* reduce unroll tensor shape -> 64x64

---------

Co-authored-by: George Hotz <[email protected]>
2026-08-04 23:25:32 -07:00
chenyuandGitHub b45058b5ec don't cast weak in _broadcasted [pr] (#17408)
* don't cast weak in _broadcasted [pr]

* fine now?
2026-08-05 02:19:31 -04:00
George HotzandGitHub 46f0003776 more KernelCountException (#17407) 2026-08-04 22:55:38 -07:00
chenyuandGitHub 9b508dfafc remove invalid special case in cast [PR] (#17405) 2026-08-04 23:08:07 -04:00
George HotzandGitHub e1f42681fa add new schedule tests + format better (#17402)
* add new schedule tests + format better

* assert_kernel_count
2026-08-04 18:46:38 -07:00
chenyuandGitHub 3eab809e06 update minimum to not create strong type const [PR] (#17401) 2026-08-04 21:29:24 -04:00
George HotzandGitHub 6122b3c98f use check_schedule in tests where possible (#17400) 2026-08-04 18:17:29 -07:00
chenyuandGitHub d79772f057 fix pow on extreme inputs (#17397)
* fix pow on extreme inputs

* WEBGPU
2026-08-04 19:30:43 -04:00
chenyuandGitHub c1a10e0726 fix _min_max for CAST from float to int [pr] (#17396)
* fix _min_max for CAST from float to int [pr]

* fix
2026-08-04 18:06:50 -04:00
George HotzandGitHub f489f4bc36 add test_eye + color INDEX (#17394) 2026-08-04 11:08:08 -07:00
b1tgandGitHub 0796853845 support symbolic shapes in allreduce (#17364) 2026-08-04 07:53:12 -07:00
qazalandGitHub c9cd44b751 more custom kernel contig input edge case tests (#17387) 2026-08-04 18:20:50 +09:00
George HotzandGitHub c21a552f3d llm: bugfixes + warmup (#17384) 2026-08-03 18:23:14 -07:00
George HotzandGitHub 3cb786f447 llm: update test_llm_server tests (#17382) 2026-08-03 16:06:17 -07:00
geohot 87289a7410 hotfix: revert test_scalar_alu_index, violates spec 2026-08-03 15:25:51 -07:00
George HotzandGitHub c2625c78cb scalar ALU index fix + llm: preserve_thinking (#17381)
* cstyle: scalar ALU index fix, serve: preserve_thinking, test: fix Handler import

- cstyle.py: return scalar directly when ALU buffer has 1 element
- cli.py: add preserve_thinking param to FallbackTemplate.render
- serve.py: pass preserve_thinking=True when rendering chat completions
- test_llm_server.py: fix import to use Handler from llm.serve

* real fix
2026-08-03 15:10:21 -07:00
chenyuandGitHub 314df72b5f deflake test_hcq with MOCKGPU (#17370)
for MOCKGPU we compare with e2e wall time which would be device agnostic
2026-08-03 13:22:59 +03:00
George HotzandGitHub 05bc7c6994 fix llm reasoning and Linear import (#17372) 2026-08-02 12:31:52 -07:00
chenyuandGitHub 59df317b12 use UOp.const to create new consts [PR] (#17368)
replace arg won't work with ConstArg
2026-08-02 13:31:55 -04:00
chenyuandGitHub 8e524ca467 CONST related cleanups [pr] (#17352)
ConstFloat(nan) != nan should be False, and some Invalid bool cleanups
2026-08-01 09:54:28 -04:00
chenyuandGitHub 6c0ec39279 UOp.is_invalid [PR] (#17351)
helper to prep ConstArg
2026-08-01 02:36:32 -04:00
chenyuandGitHub b502fc1367 more const arg -> val (#17350) 2026-08-01 02:18:10 -04:00
qazalandGitHub 161783d8f7 add _device_num back to ast.variables (kimi) (#17327) 2026-08-01 14:56:50 +09:00
George HotzandGitHub a88f832f0c remove UOp.val (#17345) 2026-07-31 18:58:38 -07:00
chenyuandGitHub 850989115d __int__ and __float__ work for weak (#17342) 2026-07-31 19:56:37 -04:00
sirhcmandGitHub 85ced44db6 tc: don't allow reduce over output dims (#17340) 2026-07-31 16:48:51 -04:00
chenyuandGitHub 277433259e fix sym_infer for CAST (#17338) 2026-07-31 14:38:38 -04:00