From a647c9eca6da182ad1fb4a39596b6dc55dee1e87 Mon Sep 17 00:00:00 2001 From: qazal <77887910+Qazalin@users.noreply.github.com> Date: Wed, 19 Nov 2025 01:27:56 +0800 Subject: [PATCH] sqtt ui minor fixes (#13335) * roc.py cleanups * direct append * viz index cleanup * simd row details --- extra/sqtt/roc.py | 6 +++--- tinygrad/viz/index.html | 2 +- tinygrad/viz/js/index.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extra/sqtt/roc.py b/extra/sqtt/roc.py index 331ff2da2b..36e478b8d6 100644 --- a/extra/sqtt/roc.py +++ b/extra/sqtt/roc.py @@ -94,14 +94,14 @@ def decode(profile:list[ProfileEvent]) -> _ROCParseCtx: ROCParseCtx = _ROCParseCtx(dev_events, sqtt_events, prog_events) @rocprof.rocprof_trace_decoder_se_data_callback_t - def copy_cb(buf, buf_size, data_ptr): + def copy_cb(buf, buf_size, _): if (prof_info:=ROCParseCtx.next_sqtt()) is None: return 0 buf[0] = ctypes.cast(prof_info, ctypes.POINTER(ctypes.c_ubyte)) buf_size[0] = len(prof_info) return len(prof_info) @rocprof.rocprof_trace_decoder_trace_callback_t - def trace_cb(record_type, events_ptr, n, data_ptr): + def trace_cb(record_type, events_ptr, n, _): match record_type: case rocprof.ROCPROFILER_THREAD_TRACE_DECODER_RECORD_OCCUPANCY: for ev in (rocprof.rocprofiler_thread_trace_decoder_occupancy_t * n).from_address(events_ptr): ROCParseCtx.on_occupancy_ev(ev) @@ -112,7 +112,7 @@ def decode(profile:list[ProfileEvent]) -> _ROCParseCtx: return rocprof.ROCPROFILER_THREAD_TRACE_DECODER_STATUS_SUCCESS @rocprof.rocprof_trace_decoder_isa_callback_t - def isa_cb(instr_ptr, mem_size_ptr, size_ptr, pc, data_ptr): + def isa_cb(instr_ptr, mem_size_ptr, size_ptr, pc, _): instr, mem_size_ptr[0] = ROCParseCtx.disasms[(unwrap(ROCParseCtx.active_kern), pc.address)] # this is the number of bytes to next instruction, set to 0 for end_pgm diff --git a/tinygrad/viz/index.html b/tinygrad/viz/index.html index ad08c448ad..a71324ca99 100644 --- a/tinygrad/viz/index.html +++ b/tinygrad/viz/index.html @@ -271,7 +271,7 @@ } #device-list > div { min-height: 32px; - width: 132px; + width: 134px; overflow-x: auto; overflow-y: hidden; white-space: nowrap; diff --git a/tinygrad/viz/js/index.js b/tinygrad/viz/js/index.js index 4a51ec787e..bf83e3e4c6 100644 --- a/tinygrad/viz/js/index.js +++ b/tinygrad/viz/js/index.js @@ -36,7 +36,7 @@ const updateProgress = ({ start, err }) => { d3.select("#custom").html(""); if (err) { displaySelection("#custom"); - d3.select("#custom").append(() => d3.create("div").classed("raw-text", true).call(s => s.append(() => codeBlock(err, "txt"))).node()); + d3.select("#custom").append("div").classed("raw-text", true).call(s => s.append(() => codeBlock(err, "txt"))).node(); } }