nimlgen/tinygrad
1
0
Fork 0
forked from tinygrad/tinygrad
Code Pull Requests Activity

viz: update browser test to properly shutdown [pr] (#10793)

Browse Source 
Using `await page.evaluate` can cause non deterministic `TargetCloseError`
exceptions if it cannot find the elements on the page, Puppeteer
doesn't cleanly stop when `browser.close()` is called.
[Failing CI](https://github.com/tinygrad/tinygrad/actions/runs/15596803685/job/43928961323?pr=10763#step:9:61)
This commit is contained in:
qazal
2025-06-12 17:58:42 +03:00
committed by GitHub
parent 24e7aed74b
commit a113c5e3ae
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/web/test_viz.js
+9 -8
View File
@@ -10,23 +10,24 @@ async function main() {
}));
// ** run browser tests
let browser;
let browser, page;
try {
browser = await puppeteer.launch({ headless: true });
const page = await browser.newPage();
page = await browser.newPage();
const res = await page.goto("http://localhost:8000", { waitUntil:"domcontentloaded" });
if (res.status() !== 200) throw new Error("Failed to load page");
const scheduleSelector = await page.waitForSelector("ul");
scheduleSelector.click();
await page.waitForSelector("rect");
const nodes = await page.evaluate(() => document.querySelectorAll("#nodes > g").length);
const edges = await page.evaluate(() => document.querySelectorAll("#edges > path").length);
if (!nodes || !edges) {
throw new Error("VIZ didn't render a graph")
}
await page.waitForFunction(() => {
const nodes = document.querySelectorAll("#nodes > g").length;
const edges = document.querySelectorAll("#edges > path").length;
return nodes > 0 && edges > 0;
});
} finally {
// ** cleanups
if (browser) await browser.close();
if (page != null) await page.close();
if (browser != null) await browser.close();
proc.kill();
}
}