nimlgen/tinygrad
1
0
Fork 0
forked from tinygrad/tinygrad
Code Pull Requests Activity

Remove unused R_AARCH64_CALL26 relocation (#8508)

Browse Source 
First iteration of the AMX fix was using symbol lookup + trampoline
approach which required this, however later i replaced it by marking
amx function `static` and assumed that relocation was still used when
callee wasn't inlined, however this turned out not to be the case
because the callee can't be moved around by linker at link-time and
can't be overloaded by other symbols (`static` means priority + local
visibility)
This commit is contained in:
uuuvn
2025-01-06 00:00:21 +03:00
committed by GitHub
parent b4f4a3ac12
commit c9c7f1be46
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tinygrad/runtime/support/elf.py
-1
View File
@@ -46,7 +46,6 @@ def relocate(instr: int, ploc: int, tgt: int, r_type: int):
rel_pg = (tgt & ~0xFFF) - (ploc & ~0xFFF)
return instr | (getbits(rel_pg, 12, 13) << 29) | (getbits(rel_pg, 14, 32) << 5)
case libc.R_AARCH64_ADD_ABS_LO12_NC: return instr | (getbits(tgt, 0, 11) << 10)
case libc.R_AARCH64_CALL26: return instr | getbits(tgt, 2, 27)
case libc.R_AARCH64_LDST16_ABS_LO12_NC: return instr | (getbits(tgt, 1, 11) << 10)
case libc.R_AARCH64_LDST32_ABS_LO12_NC: return instr | (getbits(tgt, 2, 11) << 10)
case libc.R_AARCH64_LDST64_ABS_LO12_NC: return instr | (getbits(tgt, 3, 11) << 10)